pin rollup#5570
Conversation
There was a problem hiding this comment.
Greptile Summary
This PR pins the Rollup dependency to version 4.44.2 in the package.json overrides section. This is a defensive change made in response to a breaking bug introduced in Rollup 4.45.0 that causes build failures with the error 'Cannot add property 0, object is not extensible'. By explicitly setting this version constraint, we ensure build stability across the project.
The change is minimal but important, as Rollup is a critical build tool in our dependency chain, particularly through packages like rolldown-vite. The PR references a known issue tracked at rollup/rollup#6012.
Confidence score: 5/5
- This PR is very safe to merge as it's a defensive version pin to a known working version.
- High confidence score given because this is a well-documented issue with a clear fix, and the change is minimal with a proven stable version.
- Key files to review:
- reflex/constants/installer.py (particularly the package.json OVERRIDES section)
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5570 will not alter performanceComparing Summary
|
read: rollup/rollup#6012